Pin pydantic<2 for the Python client#615
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Jul 11, 2023
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
agorajek
approved these changes
Jul 11, 2023
Member
agorajek
left a comment
agorajek
left a comment
There was a problem hiding this comment.
Yes please. And thank you @shangyian .
samredai
approved these changes
Jul 11, 2023
youngman-droid
pushed a commit
to youngman-droid/dj
that referenced
this pull request
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin pydantic<2 for the Python client as we're not compatible with the latest release.
Found this issue from running the client. Since we don't pin an upper boundary for Pydantic, client users can find themselves using pydantic>=2, which isn't compatible with our models.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan