Release/5.33.3#67
Merged
Merged
Conversation
CTRL_BREAK_EVENT delivery is unreliable on Windows — the scheduler's threading.Event.wait doesn't wake on SIGBREAK from a different thread context, so the parent's children-watcher loop never empties and Ctrl+C hangs the whole tree. Reported by Chip; reproduced on the AWS WorkSpace. The orphan-postgres bug that motivated the CTRL_BREAK_EVENT switch is already addressed by the other half of fde7321 — children call ensure_standalone_setup() instead of get_server(), so they no longer register PIDs in pgserver's on-disk handle list. Force-killing them is safe; only the parent owns the pgserver handle and exits via the normal atexit path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
datakitchen-devops
approved these changes
May 15, 2026
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes