fix: correct YRangeCursorTool annotation when cursors are inverted#307
Open
hieusats wants to merge 1 commit intoDataLab-Platform:mainfrom
Open
fix: correct YRangeCursorTool annotation when cursors are inverted#307hieusats wants to merge 1 commit intoDataLab-Platform:mainfrom
hieusats wants to merge 1 commit intoDataLab-Platform:mainfrom
Conversation
When the top Y-range cursor is dragged below the bottom cursor (ymin > ymax), the annotation label showed an invalid inequality (e.g. '5 < y < 2') and a negative delta (no physical meaning). Fix by sorting the min/max values and using abs() for the delta. Fixes DataLab-Platform#306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #306
When the top Y-range cursor is dragged below the bottom cursor (
ymin > ymax), the annotation label showed an invalid inequality (e.g.5 < y < 2) and a negative delta value (∆y=-3).Changes
In
datalab/gui/docks.py→CurveStatsToolFunctions.set_labelfuncs():min(ymin, ymax)/max(ymin, ymax)to always display the smaller value on the leftabs(ymax - ymin)so delta is always positiveTest Plan
min()/max()ensures correct ordering,abs()ensures positive delta