Skip to content

Conversation

@thapacodes4u
Copy link
Contributor

Summary

Refactors the slider column asset registration to match the pattern used in the catalogue plugin for consistency across packages.

Changes

  • Restructured asset directory from resources/dist/ to resources/css/ and resources/js/
  • Updated CommonServiceProvider to use __DIR__ paths instead of asset() helper

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.74%. Comparing base (330c775) to head (7897f74).

Additional details and impacted files
@@            Coverage Diff            @@
##               main       #9   +/-   ##
=========================================
  Coverage     15.74%   15.74%           
  Complexity       89       89           
=========================================
  Files            13       13           
  Lines           254      254           
=========================================
  Hits             40       40           
  Misses          214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SlimDeluxe
Copy link
Member

I think a plugin should contain 1 asset file and not separate ones for each feature? Unless Filament has a CSS/JS merge function for production, to reduce the number of files and therefore HTTP requests?
With Sass and Less CSS preprocessors, one can still separate component CSS/JS into own files and then import them into a top-level file. But I think we are not using them here?

@SlimDeluxe
Copy link
Member

@thapacodes4u please see my previous comment

@thapacodes4u
Copy link
Contributor Author

@SlimDeluxe Changes we did here was already added through another PR so we don't need this PR anymore and closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants