Skip to content

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

@KilianTrunk KilianTrunk marked this pull request as draft September 24, 2025 18:28
@KilianTrunk KilianTrunk marked this pull request as ready for review September 25, 2025 08:46
@SlimDeluxe
Copy link
Member

Just curious, most of the files changed are simply using imports instead of FQCN names for classes in the code. How was this triggered? By the upgrade tool, your editor... ?

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, please update the tests workflow.

@KilianTrunk
Copy link
Contributor Author

@SlimDeluxe correct, these changes are from the upgrade tool from filament. it sucks it didn’t really fix much stuff (had to do it manually), only changed these imports and told me what to upgrade in the composer

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There's an error on the users page (wrong class import)
  • getPermissionPrefixes() do not seem to be respected anymore, all permission groups now include all permissions for a resource
  • "My settings" page is now half the width
  • There's an error on the profile page

@SlimDeluxe
Copy link
Member

I see the test failing since it's pulling the common package from the main branch on upstream.
We have 2 options:

  1. Set the repo and branch to your own (in composer.json)
  2. Make sure UI has no problems, CLI tests work locally and then just wait for f4 branch to be merged in common

@SlimDeluxe SlimDeluxe merged commit eab5728 into DataLinx:f4 Oct 8, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants