-
Notifications
You must be signed in to change notification settings - Fork 4
feat: migrate to f4 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just curious, most of the files changed are simply using imports instead of FQCN names for classes in the code. How was this triggered? By the upgrade tool, your editor... ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please update the tests workflow.
|
@SlimDeluxe correct, these changes are from the upgrade tool from filament. it sucks it didn’t really fix much stuff (had to do it manually), only changed these imports and told me what to upgrade in the composer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There's an error on the users page (wrong class import)
-
getPermissionPrefixes()do not seem to be respected anymore, all permission groups now include all permissions for a resource - "My settings" page is now half the width
- There's an error on the profile page
|
I see the test failing since it's pulling the common package from the main branch on upstream.
|
No description provided.