Skip to content

feat(tariff-codes): implement tariff codes#17

Merged
SlimDeluxe merged 6 commits intoDataLinx:mainfrom
KilianTrunk:feat/tariff-codes
Sep 11, 2025
Merged

feat(tariff-codes): implement tariff codes#17
SlimDeluxe merged 6 commits intoDataLinx:mainfrom
KilianTrunk:feat/tariff-codes

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 86.45533% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.24%. Comparing base (421264d) to head (b24c82e).

Files with missing lines Patch % Lines
src/Jobs/ImportTariffCodes.php 84.26% 31 Missing ⚠️
src/Console/Commands/ImportTariffCodesCommand.php 0.00% 9 Missing ⚠️
...nt/Clusters/World/Resources/TariffCodeResource.php 95.50% 4 Missing ⚠️
src/Policies/TariffCodePolicy.php 90.00% 2 Missing ⚠️
...urces/TariffCodeResource/Pages/ListTariffCodes.php 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #17      +/-   ##
============================================
+ Coverage     82.14%   83.24%   +1.10%     
- Complexity      160      261     +101     
============================================
  Files            25       31       +6     
  Lines          1008     1355     +347     
============================================
+ Hits            828     1128     +300     
- Misses          180      227      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This section is not necessary
Image
  • In the above screen, it's not clear in which language the code is being created/edited. If it's not easy, keep it and let's revisit it later when your new multi-lang text input component is merged.
  • The CN names should be transformed, since by themselves they are very unclear... Let's try to remove dashes from the start of the string, then prefix with all the parents and use > for the separator. So 010129 should be named: "Live horses, asses, mules and hinnies > Other". Make sure all the parts start with the uppercase letter (see Slovenian)
  • Remove the year from the interface completely, at least for now.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't include any level 1 names in the CN name
Image
  • Make all name parts uppercase
Image
  • When importing in my case, I ran out of memory. Either do some optimization (eg. only import for one language at a time) or increase the mem limit
Image
  • Bc of the memory problem, I imported English first, then Slovenian, but that blanked all the English names
Image

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 more fix is needed.

  • With "uppercase", I meant only the first letter of each part... Sorry for not making it more clear, although I did add an image 😅

@SlimDeluxe
Copy link
Member

Ah yes, capitalize is what I should have written 😅
All is good now, merging 👍

@SlimDeluxe SlimDeluxe merged commit 2b08899 into DataLinx:main Sep 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants