feat(tariff-codes): implement tariff codes#17
Merged
SlimDeluxe merged 6 commits intoDataLinx:mainfrom Sep 11, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
============================================
+ Coverage 82.14% 83.24% +1.10%
- Complexity 160 261 +101
============================================
Files 25 31 +6
Lines 1008 1355 +347
============================================
+ Hits 828 1128 +300
- Misses 180 227 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SlimDeluxe
requested changes
Sep 1, 2025
Member
There was a problem hiding this comment.
- This section is not necessary
- In the above screen, it's not clear in which language the code is being created/edited. If it's not easy, keep it and let's revisit it later when your new multi-lang text input component is merged.
- The CN names should be transformed, since by themselves they are very unclear... Let's try to remove dashes from the start of the string, then prefix with all the parents and use > for the separator. So 010129 should be named: "Live horses, asses, mules and hinnies > Other". Make sure all the parts start with the uppercase letter (see Slovenian)
- Remove the year from the interface completely, at least for now.
SlimDeluxe
requested changes
Sep 3, 2025
Member
There was a problem hiding this comment.
- Don't include any level 1 names in the CN name
- Make all name parts uppercase
- When importing in my case, I ran out of memory. Either do some optimization (eg. only import for one language at a time) or increase the mem limit
- Bc of the memory problem, I imported English first, then Slovenian, but that blanked all the English names
SlimDeluxe
requested changes
Sep 10, 2025
Member
SlimDeluxe
left a comment
There was a problem hiding this comment.
Only 1 more fix is needed.
- With "uppercase", I meant only the first letter of each part... Sorry for not making it more clear, although I did add an image 😅
Member
|
Ah yes, capitalize is what I should have written 😅 |
SlimDeluxe
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.