RedundantColumnRemover no longer removes StoreProvider's columns for groupings #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kulakov
changed the title
AlexUstinov
reviewed
Jan 29, 2021
Orm/Xtensive.Orm/Orm/Rse/Transformation/ColumnMappingInspector.cs
Outdated
Show resolved
Hide resolved
AlexUstinov
previously approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of GroupBy there are several SQL queries
RedundantColumnRemoverdoes not take into account additional queries and in case ofQuery.Store()operation it could remove columns that additional queries can use. (see the test class for query example)The PR makes column optimization to treat all the columns of
Query.Store()operation as used when grouping is applied. This prevents columns from being removed from Temporary table and additional queries will work as intended.Additionally, it formats some code and improves
.ToList()/.ToArray()operations withinColumnMappingInspector(base class forRedundantColumnRemover)