Fixes some problems that caused failed tests in Xtensive.Orm.Tests.Core #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to CultureInfo is not marked as Serializable we have to serialize it manually
- serialization tests for different comparers - removed commented tests that were commented since inital import - new formatting applied
AlexUstinov
previously approved these changes
Mar 15, 2021
Co-authored-by: Aleksandr Ustinov <alex.ustinov@servicetitan.com>
alex-kulakov
added a commit
that referenced
this pull request
Jun 22, 2023
* Move SqlInsertValuesCollection to Dml.Collections folder * Add rows collection to SqlInsert + mark Values as obsolete * Test for SqlInsert * Correct switch from strict number of conditions to default number of conditions - Return back WellKnown.MaxNumberOfConditions as [Obsolete]; - Add WellKnown.DefaultMaxNumberOfConditions as replacement; - Initialize MultiRowInsertLevel2BatchSize with DefalultMaxNumberOfConditions; * Proper implementation of DomainConfiguration.MaxNumberOfConditions - check if configuration instance is locked and deny changing if it is; - initialized with well-known constant instead of literal value; - added configuration element to have support for this parameter in *.config files * fix * Add test for loading of DomainConfiguration with new property from config files Offtop: tagLocation and other forgotten-to-add properties are tested * Fix wrong translation of values section * DomainConfiguration cloning clones MaxNumberOfConditions * Return original types of properties in IPersistDescriptor Keeps backwards compatibility * Multi-row insert not only for 1-column tuples - adds PersistParameterBinding.RowIndex + ctors to init the value, by default row index is 0. This property will keep track of what row of SqlPersistTask.Tuples is the source of value - CommandFactory uses dedicated algorithms for Tuple and for collection of Tuples. First one keeps original algorithm before any changes, and the second one uses RowIndex to get required row and FieldIndex to find value within row - return original private SqlSessionHandler.Store() method, it works without checking for count of values in tuples. * No use of SqlInsert.Values, SqlInsert.ValueRows - new InsertSection.NewRow removed, no need in it - SqlInsert.Values type returned to original Dictionary, removed internal collection type and. - all usages of SqlInsert.Values * IMultiRecordPersistDescriptor-related changes - the interface properties renamed - added lazy alternative for one-row request with default implementation to IPersistRecord.StoreRequest. This keeps original interface API and have lazy request. TemporaryTableDescriptor uses only lazy properties as well as TemporaryTableManager, original StoreRequest implementaion in TemporaryTableDescriptor returns Lazy<>.Value and hidded. - WellKnown constants renamed accordingly to IMultiRecordPersistDescriptor properties - added summaries for interfaces' properties and WellKnown constants * Rename file containing interfaces * Remove unused code + commited code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of what's made:
ChainedBufferTestis now in right namespace.ISerializable.GetObjectData()method implementations inSerializableExpressionswere marked as[SecurityCritical]like they suppose to be (actually this is an off-topic change, I did it for good measure since I'd already been working on serialization :) )ThreadingTestlost itsAsyncpart (I commented it out) because there is no support forBeginInvoke/EndInvokemethods this part used.