TupleDescriptor performance improvements#14
Merged
alex-kulakov merged 31 commits intoDataObjects-NET:masterfrom Apr 9, 2020
Merged
TupleDescriptor performance improvements#14alex-kulakov merged 31 commits intoDataObjects-NET:masterfrom
alex-kulakov merged 31 commits intoDataObjects-NET:masterfrom
Conversation
# Conflicts: # Extensions/Xtensive.Orm.BulkOperations/Internals/ExpressionVisitor.cs
…StripNullable call.
… faster than IsGeneric)
…implify PackedFieldDescriptor implementation
# Conflicts: # Orm/Xtensive.Orm/Tuples/Packed/TupleLayout.cs
…and to improve performance
SergeiPavlov
reviewed
Apr 2, 2020
SergeiPavlov
previously approved these changes
Apr 2, 2020
SergeiPavlov
reviewed
Apr 2, 2020
…oid repeating array indexing
alex-kulakov
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request mainly contains changes to speed up TupleDescriptor creation. It also reduces memory consumption by storing PackedFieldDescriptors in a compact
structs instead of overflown with data fieldsclasses.There are other performance improvements (See commit messages).
The table below presents results of benchmarking of
TupleDescriptor.Createmethod for tuples of length 1, 2, 3, 4 and 45.