Optimizations: allocations in RecordSetHeader.Join(); use IReadOnlyList instead of ReadOnlyList to save allocations #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st instead of ReadOnlyList to save allocations (#32) * Optimizations: allocate List<> with known capacity; use IReadOnlyList instead of ReadOnlyList * Optimize hot paths: replace LINQ by foreach
alex-kulakov
requested changes
Aug 24, 2021
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
The changes are mostly OK. Some changes are required though. I have suggested changes to apply where I could. SqlColumnCollection lacks copyright update and that I couldn't suggest
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Contributor
Author
Changed its copyright line: b930c31 |
alex-kulakov
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling shows significant heap allocations in these places, which are suboptimal.
ReadOnlyListwrapper is unnecessary, because since .NET 45List<>implementsIReadOnlyList