Get rid of custom Copy methods for arrays. No array copying if not needed #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of unnecessary array copies. # Conflicts: # Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IncludeProvider.cs
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
SelectProvider and IncludeProvider classes' constructors had arrays of integer as input parameter, now IncludeProvider has same constructor with new type of the parameter that used to be array of integer but SelectProvider has got an additional constructor. Apparently, int[] can cast to IReadOnlyList<int, why use it in one case and not use in in another?
…copy # Conflicts: # Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IncludeProvider.cs # Orm/Xtensive.Orm/Tuples/TupleDescriptor.cs
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
Now seems to be OK to merge
alex-kulakov
approved these changes
Apr 15, 2020
alex-kulakov
pushed a commit
that referenced
this pull request
Sep 10, 2020
…d to thread contention and to lock convoy issue (#16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal of this PR is to eliminate array cloning when it is returned from inside a class as a property value. The purpose of cloning is to protect internal array from modifications so we can just wrap this instance to read only collection instance instead of cloning.