TypeHelper class code formatting and performance improvements#19
Merged
alex-kulakov merged 3 commits intoDataObjects-NET:masterfrom Apr 16, 2020
Merged
TypeHelper class code formatting and performance improvements#19alex-kulakov merged 3 commits intoDataObjects-NET:masterfrom
alex-kulakov merged 3 commits intoDataObjects-NET:masterfrom
Conversation
alex-kulakov
previously approved these changes
Apr 7, 2020
Contributor
|
Hello, thank you for the contribution. Seems to be OK |
…ethods performance
…e etc methods in TypeHelper class # Conflicts: # Orm/Xtensive.Orm/Orm/Linq/QueryHelper.cs
alex-kulakov
approved these changes
Apr 16, 2020
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
New changes are also OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeHelper.Activatemethod now uses constructor it found rather than always falling back toActivator.CreateInstancemethod;StringComparison.Ordinalorchararguments are now used while processing strings;IsNullableby removing redundant checks;IsAnonimousandIsClosuremethods by faster string comparison also by usingType.IsDefinedrather thanAttribute.IsDefined(the faster way to call the same check) and by reordering operations in criteria to put faster operations first;typeofoperators to eliminate expensive system calls