Split type-unsafe InternalQueryCache into 4 statically typed caches#194
Merged
alex-kulakov merged 13 commits intoDataObjects-NET:masterfrom Dec 15, 2021
Conversation
Contributor
SergeiPavlov
commented
Nov 24, 2021
SergeiPavlov
commented
- Split type-unsafe InternalQueryCache into three statically typed caches
- Remove unused indexSeekCachingRegion
- Make BuildEntitySetTypeState static delegate
- Rename EntitySetTask.CacheKey -> ItemsQueryCacheKey
- Make CacheKey structs readonly
alex-kulakov
requested changes
Dec 10, 2021
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
alex-kulakov
previously approved these changes
Dec 15, 2021
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
Pretty much ok. Just apply the whitespace removals.
Contributor
|
Also the PR requires conflicts resolve |
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Contributor
Author
I dont see any conflicts with master branch |
alex-kulakov
approved these changes
Dec 15, 2021
Contributor
|
My bad, yes, it's fine, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.