Optimize SqlFunctionCall/SqlCustomFunctionCall #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kulakov
requested changes
Jul 19, 2022
Contributor
|
Also worth mentioning that FunctionCalls lost ability to change parameters after creation. |
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Contributor
Author
I mentioned in the PR description that |
Contributor
|
Yes, you did, pardon me for inattention. |
alex-kulakov
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlFunctionCallBasewith functionality common for bothSqlFunctionCall&SqlCustomFunctionCallSqlFunctionCall.ArgumentstoIReadOnlyListto avoid unnecessary allocations. Argument list is now immutable.Collection<SqlExpression>toList<SqlExpression>. List is more lightweight with same functionalityArgumentValidator.EnsureArgumentIs<T>()to returnTto avoid double type casting after callparameterNameautomatic by using[CallerArgumentExpression]attributeEnsureArgumentNotNullbeforeEnsureArgumentIsbecause the later checks fornullas well.