-
Notifications
You must be signed in to change notification settings - Fork 27
Add support of DateOnly/TimeOnly types #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of DateOnly/TimeOnly types #251
Conversation
Fix formatting Fix tests
…oProvider.cs Co-authored-by: Oleg Shuruev <shuruev@gmail.com>
…oProvider.cs Co-authored-by: Oleg Shuruev <shuruev@gmail.com>
|
This is great PR! I appreciate it. I'll merge it to a proxy branch where I add support for these times to other providers. |
|
But instead of DO_DATEONLY I would use the built-in NET6 compile time variable, so I will remove this env var mentions from the code, are you OK with it? |
It would be Ok for us but not for other DO users. But if you can implements other providers, then OK With other DB engine the tests will fail under .NET6 without |
|
SQL's |
Experimental implementation for MSSQL only
Enabled by conditional compilation for .NET6
It can be disabled by setting env var
DO_DATEONLY=falseor by property inUser.Directory.Build.props