Use C#9 Covariant return types feature for Clone() implementation for type safety and reduce number of casts#261
Conversation
|
Please, do not merge master to here before fixing building issues. |
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
THe build is fixed |
Nice. thank you |
|
Error appeared on our build server after merge: Orm\Xtensive.Orm\Sql\Dml\Expressions\SqlExtract.cs(75,62): error CS8821: A static anonymous function cannot contain a reference to 'this' or 'base'. |
Thank you! |
|
@SergeiPavlov, please, merge changes from master, I'll pull-request to st fork on top of this merge to fix minor issues with SqlTruncateTable cloning and make it ready to merge. Merge of SqlInsert will cause some problems. |
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
Everything seems to be good except for new node - SqlTruncateTable, which has old cloning which breaks building. I would also add line between field and property in the SqlNodeCloneContext, I suggested this change for you to be easy to apply.
There are some merge issues, partially from master but they were resolved in master. SqlInsert will be problematic merge
Co-authored-by: Alexey Kulakov <alexey.kulakov@dataobjects.net>
|
Fixed build
Do you mean this line? https://github.com/DataObjects-NET/dataobjects-net/pull/261/files#diff-84e02d093b91d61040b7c79479c67936f1a88cfd9cca87c9f6e3a8899566c166R13 It already presents |
|
Thank you.
It wasn't, otherwise I wouldn't be able to make suggestion, right? I don't know what happened. Anyway, this is good that it is exists. Thank you once again |
2 participants
No description provided.