Skip to content

Optimization: avoid 2-level cache in AttributeHelper #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-kulakov merged 2 commits into from
Aug 24, 2023
Merged

Optimization: avoid 2-level cache in AttributeHelper #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71b0583
Optimization: avoid 2-level cache in AttributeHelper
SergeiPavlov Jan 4, 2023
bb1fb8c
Update Orm/Xtensive.Orm/Reflection/AttributeHelper.cs
SergeiPavlov Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 56 additions & 72 deletions Orm/Xtensive.Orm/Reflection/AttributeHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
using System.Linq;
using System.Reflection;
using Xtensive.Core;
using AttributesKey = System.ValueTuple<System.Reflection.MemberInfo, System.Type, Xtensive.Reflection.AttributeSearchOptions>;
using PerAttributeKey = System.ValueTuple<System.Reflection.MemberInfo, Xtensive.Reflection.AttributeSearchOptions>;
using Xtensive.Core;

namespace Xtensive.Reflection
{
Expand All @@ -21,22 +19,65 @@ namespace Xtensive.Reflection
/// </summary>
public static class AttributeHelper
{
internal class AttributeExtractors<TAttribute> where TAttribute : Attribute
{
internal static readonly Func<PerAttributeKey, TAttribute[]> AttributesExtractor = key => {
var uncasted = GetAttributes(key.Item1, typeof(TAttribute), key.Item2);
return uncasted.Count > 0
? uncasted.Cast<TAttribute>().ToArray(uncasted.Count)
: Array.Empty<TAttribute>();
};
}

private static class AttributeDictionary<TAttribute> where TAttribute : Attribute
{
private static readonly Type attributeType = typeof(TAttribute);
public static readonly ConcurrentDictionary<PerAttributeKey, TAttribute[]> Dictionary = new();
}

private static readonly ConcurrentDictionary<AttributesKey, IReadOnlyList<Attribute>> AttributesByMemberInfoAndSearchOptions = new();
public static readonly Func<PerAttributeKey, TAttribute[]> AttributesExtractor = ExtractAttributesByKey;

private static TAttribute[] ExtractAttributesByKey(PerAttributeKey key)
{
var (member, options) = key;

var attributesAsObjects = member.GetCustomAttributes(attributeType, false);
var attributesCount = attributesAsObjects.Length;

var attributes = attributesCount > 0
? attributesAsObjects.Cast<TAttribute>().ToList(attributesCount)
: null;

if (options != AttributeSearchOptions.InheritNone) {
if (attributesCount == 0) {
if ((options & AttributeSearchOptions.InheritFromPropertyOrEvent) != 0
&& member is MethodInfo m
&& ((MemberInfo) m.GetProperty() ?? m.GetEvent()) is MemberInfo poe) {
attributes = GetAttributesAsNewList(poe);
}
if ((options & AttributeSearchOptions.InheritFromBase) != 0
&& (options & AttributeSearchOptions.InheritFromAllBase) == 0) {
AddAttributesFromBase(ref attributes, member, options);
}
}

if ((options & AttributeSearchOptions.InheritFromAllBase) != 0
&& member.DeclaringType != WellKnownTypes.Object) {
AddAttributesFromBase(ref attributes, member, options);
}
}

return attributes?.ToArray(attributes.Count) ?? Array.Empty<TAttribute>();
}

private static List<TAttribute> GetAttributesAsNewList(MemberInfo member)
{
var attrObjects = member.GetCustomAttributes(attributeType, false);
var attrs = new List<TAttribute>(attrObjects.Length);
for (int i = 0, count = attrObjects.Length; i < count; ++i) {
attrs.Add((TAttribute) attrObjects[i]);
}
return attrs;
}

private static void AddAttributesFromBase(ref List<TAttribute> attributes, MemberInfo member, AttributeSearchOptions options)
{
if (member.GetBaseMember() is MemberInfo bm) {
var attrsToAdd = bm.GetAttributes<TAttribute>(options);
if (attrsToAdd.Count > 0) {
(attributes ??= new List<TAttribute>(attrsToAdd.Count)).AddRange(attrsToAdd);
}
}
}

/// <summary>
/// A shortcut to <see cref="MemberInfo.GetCustomAttributes(Type,bool)"/> method.
Expand All @@ -48,7 +89,7 @@ private static class AttributeDictionary<TAttribute> where TAttribute : Attribut
///
public static IReadOnlyList<TAttribute> GetAttributes<TAttribute>(this MemberInfo member, AttributeSearchOptions options = AttributeSearchOptions.InheritNone)
where TAttribute : Attribute =>
AttributeDictionary<TAttribute>.Dictionary.GetOrAdd(new PerAttributeKey(member, options), AttributeExtractors<TAttribute>.AttributesExtractor);
AttributeDictionary<TAttribute>.Dictionary.GetOrAdd(new PerAttributeKey(member, options), AttributeDictionary<TAttribute>.AttributesExtractor);

/// <summary>
/// A version of <see cref="GetAttributes{TAttribute}(MemberInfo, AttributeSearchOptions)"/>
Expand All @@ -74,62 +115,5 @@ public static TAttribute GetAttribute<TAttribute>(this MemberInfo member, Attrib
typeof(TAttribute).GetShortName()))
};
}

private static IReadOnlyList<Attribute> GetAttributes(MemberInfo member, Type attributeType, AttributeSearchOptions options) =>
AttributesByMemberInfoAndSearchOptions.GetOrAdd(
new AttributesKey(member, attributeType, options),
ExtractAttributes
);

private static List<Attribute> GetAttributesAsNewList(this MemberInfo member, Type attributeType)
{
var attrObjects = member.GetCustomAttributes(attributeType, false);
var attrs = new List<Attribute>(attrObjects.Length);
for (int i = 0, count = attrObjects.Length; i < count; ++i) {
attrs.Add((Attribute) attrObjects[i]);
}
return attrs;
}

private static IReadOnlyList<Attribute> ExtractAttributes((MemberInfo member, Type attributeType, AttributeSearchOptions options) t)
{
(var member, var attributeType, var options) = t;

var attributesAsObjects = member.GetCustomAttributes(attributeType, false);
var attributesCount = attributesAsObjects.Length;

var attributes = attributesCount > 0
? attributesAsObjects.Cast<Attribute>().ToList(attributesCount)
: null;

if (options != AttributeSearchOptions.InheritNone) {
if (attributesCount == 0) {
if ((options & AttributeSearchOptions.InheritFromPropertyOrEvent) != 0
&& member is MethodInfo m
&& ((MemberInfo) m.GetProperty() ?? m.GetEvent()) is MemberInfo poe) {
attributes = poe.GetAttributesAsNewList(attributeType);
}
if ((options & AttributeSearchOptions.InheritFromBase) != 0
&& (options & AttributeSearchOptions.InheritFromAllBase) == 0
&& member.GetBaseMember() is MemberInfo bm) {
var attrsToAdd = GetAttributes(bm, attributeType, options);
if (attrsToAdd.Count > 0) {
(attributes ??= new List<Attribute>(attrsToAdd.Count)).AddRange(attrsToAdd);
}
}
}

if ((options & AttributeSearchOptions.InheritFromAllBase) != 0
&& member.DeclaringType != WellKnownTypes.Object
&& member.GetBaseMember() is MemberInfo bm2) {
var attrsToAdd = GetAttributes(bm2, attributeType, options);
if (attrsToAdd.Count > 0) {
(attributes ??= new List<Attribute>(attrsToAdd.Count)).AddRange(attrsToAdd);
}
}
}

return (IReadOnlyList<Attribute>) attributes ?? Array.Empty<Attribute>();
}
}
}