Cache tuple value accessors by argument type. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kulakov
approved these changes
May 14, 2020
Contributor
|
Thank you for you contribution. The changes are ready to merge so I merge them. |
alex-kulakov
pushed a commit
that referenced
this pull request
Jul 1, 2021
…se() on memoized array; breaking changes of interface to IReadOnlyList (#30) * Fix critical bug with attribute reordering by destructive Array.Reverse() on memoized array; breaking changes of interface to IReadOnlyList * ReversedReadOnlyList<T> helper class * Make ReversedReadOnlyList struct for efficiency * LF at EOF * readonly struct * internal ReversedReadOnlyStruct * make ReversedReadOnlyList in arg * Remove inefficiend ReveredReadOnlyList struct; enumerate arrays directly in reveres order * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no huge variety of possible value types in any reasonable domain mode.
This amount is restricted by amount of primitive types plus a number of types in certain model.
Taking this into account we can cache accessors.