Skip to content

Conversation

@SergeiPavlov
Copy link
Contributor

Most typical TextNode is comma+space
Cached queries may contain Megabytes of them:
image

@SergeiPavlov SergeiPavlov changed the title Intern short (1..2 chars) contents of TextNode Intern short (1..2 chars) contents of TextNode; Statically preallocate Comma TextNode as mostly used Jan 14, 2023
@alex-kulakov
Copy link
Contributor

I'm going to change target branch to the 7.1 one, it's the version where reworked ContainerNode was introduced sounds reasonable to improve it there

@alex-kulakov alex-kulakov changed the base branch from master to 7.1 August 2, 2023 06:36
Copy link
Contributor

@alex-kulakov alex-kulakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static TextNode.Create(string ) methods, as all static methods should be before any instance methods.
So the order should be

  1. public readonly string Test;
  2. public static TextNode Create(string text) ...
  3. internal override void AcceptVisitor(NodeVisitor vistor)

@SergeiPavlov
Copy link
Contributor Author

Static TextNode.Create(string ) methods, as all static methods should be before any instance methods.

done

@alex-kulakov alex-kulakov merged commit e081bf4 into DataObjects-NET:7.1 Aug 3, 2023
@SergeiPavlov SergeiPavlov deleted the upstream/InternShortStrings branch September 8, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants