Skip to content

Conversation

@SergeiPavlov
Copy link
Contributor

SqlClient 5.1.0 has support of DateOnly/TimeOnly types
No need for intermediate conversion

@alex-kulakov
Copy link
Contributor

alex-kulakov commented Mar 6, 2023

If you update a storage-specific thing, don't change base implementation, change and override in the the provider, changing the base one can break and probably will break other providers.

@alex-kulakov
Copy link
Contributor

I'm going to publish an RC version of 7.1 with DateOnly/TimeOnly support across all supported types of storages (PR #307). This PR fits it too. But with exception of these two no merges will happen before RC.

@SergeiPavlov
Copy link
Contributor Author

If you update a storage-specific thing, don't change base implementation, change and override in the the provider, changing the base one can break and probably will break other providers.

Fixed

@alex-kulakov
Copy link
Contributor

Also, for the future, TypeMapper has clear structure of grouped methods, It would be appreciated if ReadXxx, BindXxx and MapXxx methods were added in their groups. It would smooth review process and give you extra points of karma 😉

@alex-kulakov alex-kulakov merged commit 1a0b7f2 into DataObjects-NET:master-date-and-time-support Mar 7, 2023
@SergeiPavlov SergeiPavlov deleted the upstream/UpgradeSqlClient branch March 8, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants