Set of improvements of Sql translation subsystem #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allocations in SqlTableRef
alex-kulakov
requested changes
May 26, 2020
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
Hello. The PR is mostly is OK. Please take a look at the comments I left. And also it has a weird change of Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.cs - somehow it became changed entirely at the commit ec74285
Orm/Xtensive.Orm/Sql/Dml/Collections/SqlTableColumnCollection.cs
Outdated
Show resolved
Hide resolved
alex-kulakov
approved these changes
May 29, 2020
Contributor
|
Thank you for corrections. PR is merged. |
alex-kulakov
pushed a commit
that referenced
this pull request
Aug 24, 2021
…st instead of ReadOnlyList to save allocations (#32) * Optimizations: allocate List<> with known capacity; use IReadOnlyList instead of ReadOnlyList * Optimize hot paths: replace LINQ by foreach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes unnecessary memory allocations as well as few cases of double processing.