Makes IEnumberable<T>.Contains work with Bulk operations #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performs rewrites like
localCollection.Contains(value) -> value.In(localCollection)
AlexUstinov
suggested changes
May 28, 2020
| } | ||
|
|
||
| if (methodInfo.DeclaringType == typeof(QueryableExtensions) && | ||
| methodInfo.Name == "In" && |
Contributor
There was a problem hiding this comment.
It is better to use StringComparison.Ordinal on a hot paths like expression tree processing.
AlexUstinov
reviewed
May 28, 2020
| //rewrite localCollection.Contains(entity.SomeField) -> entity.SomeField.In(localCollection) | ||
| if (methodInfo.DeclaringType == typeof(Enumerable) && | ||
| methodInfo.Name == "Contains" && | ||
| string.Equals(methodInfo.Name, "Contains", StringComparison.OrdinalIgnoreCase) && |
AlexUstinov
approved these changes
May 30, 2020
alex-kulakov
pushed a commit
that referenced
this pull request
Dec 21, 2021
…ay (#33) * Optimizing refactoring: use ArraySegment instead of allocating subarray * Copyright lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in main assembly it rewrites calls like localCollection.Contains(value) with usage of In extension method like value.In(IncludeAlgorithm.ComplexCondition, localCollection)
Fix for issue #20