Fix comparison with local entity, part 2 #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added new cases which can check changing parts of translation
- Translator.Visit ignores expressions marked non-visitable. - GetEntityFields improved to not use additional Conditional expression wrapping already existing expression - both methods get IReadOnlyList instead of IEnumerable, it gives opportunity to use count of items to initialize capacity of Lists and not waste memory and time on resize of inner arrays
…ssions This improve compatibility of tests with some of providers
alex-kulakov
deleted the
6.0-incorrect-comparison-with-local-entity-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional cases of wrong entity equality/inequality comparison revealed, so additional changes applied after original changes of #375
Translator.Visitmethod, because they don't need to be visited and, in fact, visiting of these expressions will harm translation;Translator.GetEntityFieldsis optimized to not have additional conditional expression over one it builds, which is redundant.