Expression performance #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kulakov
requested changes
Jul 29, 2020
Contributor
alex-kulakov
left a comment
alex-kulakov
left a comment
There was a problem hiding this comment.
Almost everything is ok. Several changes need to be corrected though.
Orm/Xtensive.Orm/Orm/Linq/Expressions/StructureFieldExpression.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@alex-kulakov please see new commit with formatting changes. |
alex-kulakov
approved these changes
Aug 7, 2020
alex-kulakov
pushed a commit
that referenced
this pull request
Oct 25, 2021
* Optimizing refactoring: make TranslatorState struct * Use 'in' modifier with TranslatorState passing * Use 'in' modifier in TranslatorState constructor
alex-kulakov
added a commit
that referenced
this pull request
Oct 25, 2021
…rState Optimizing refactoring: make TranslatorState struct (#41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of performance improvements for XxxExpression types. These improvements mostly related to memory allocation. We avoiding closure allocation in several cases plus we pre-allocate
Lists when eventual length is known. Additionally on critical paths we useStringComparison.Ordinal.The rest of the changes is code formatting improvements.