No exception overwriting when it happens on upgrade transaction commit#454
Merged
alex-kulakov merged 8 commits into7.2from Mar 2, 2026
Merged
Conversation
If transaction has become broken during commit its rollback leads to new exception which will overwrite the original one. Check for active transaction should work because on exception within driver.CommitTransaction() active transaction is set to NULL.
This reverts commit 8883711.
This reverts commit 0dbe360.
# Conflicts: # ChangeLog/7.2.1-dev.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes exception happens on attempt to commit changes, for example in case of operation timeout. If so, transaction's rollback leads to different exception and hides the original cause of failure. This PR adds extra check for active transaction before attempt to rollback it in
catchpart oftry-catch