Skip to content

Net standard 21#50

Closed
AlexUstinov wants to merge 78 commits intomasterfrom
net-standard-21
Closed

Net standard 21#50
AlexUstinov wants to merge 78 commits intomasterfrom
net-standard-21

Conversation

@AlexUstinov
Copy link
Copy Markdown
Contributor

This PR makes project .Net Standard 2.1 compatible.
This is a move towards the suggested migration to .Net Core 3.1 (See #11).

AlexUstinov and others added 30 commits April 6, 2020 21:21
# Conflicts:
#	Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/IncludeProvider.cs
#	Orm/Xtensive.Orm/Tuples/TupleDescriptor.cs
It is to expensive to get values of Strings.Xxx properties when those are not needed for actual logging

# Conflicts:
#	Orm/Xtensive.Orm/Orm/Entity.cs
…g small delegate cache in Expression.CreateLambda()
@alex-kulakov
Copy link
Copy Markdown
Contributor

The PR contains a lot of changes which are not relevant to .NET Standard 2.1 migration - a lot of summaries for classes, changes of SqlExtactor API, a test for FastLambdaExpressions and so on. Is there any explanation why are they here?

I assume migration to .NET Standard should contain changes of target framework for projects and some changes for code migration if needed.

# Conflicts:
#	Extensions/Xtensive.Orm.BulkOperations/Internals/SetOperation.cs
#	Orm/Xtensive.Orm.Tests.Core/Linq/LambdaExpressionFactoryTests.cs
#	Orm/Xtensive.Orm/Orm/Domain.cs
#	Orm/Xtensive.Orm/Orm/Linq/Expressions/EntityExpression.cs
#	Orm/Xtensive.Orm/Orm/Linq/Expressions/EntityFieldExpression.cs
#	Orm/Xtensive.Orm/Orm/Linq/Expressions/FieldExpression.cs
#	Orm/Xtensive.Orm/Orm/Linq/Expressions/ItemProjectorExpression.cs
#	Orm/Xtensive.Orm/Orm/Linq/Expressions/StructureExpression.cs
#	Orm/Xtensive.Orm/Orm/Linq/Expressions/StructureFieldExpression.cs
#	Orm/Xtensive.Orm/Orm/Linq/LinqBindingCollection.cs
#	Orm/Xtensive.Orm/Orm/Linq/QueryHelper.cs
#	Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.Helpers.cs
#	Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.cs
#	Orm/Xtensive.Orm/Orm/Rse/Transformation/Internals/SkipTakeRewriterState.cs
#	Orm/Xtensive.Orm/Sql/Dml/Collections/SqlTableColumnCollection.cs
#	Orm/Xtensive.Orm/Sql/Dml/SqlQueryRef.cs
#	Orm/Xtensive.Orm/Sql/Dml/SqlTableRef.cs
# Conflicts:
#	.gitignore
#	Publish/NuGetPublish.csproj
Comment thread Version.props Outdated
@alex-kulakov
Copy link
Copy Markdown
Contributor

alex-kulakov commented Sep 9, 2020

Doesn't build at all. FastExpression.cs has two methods with the same signature but different body. Maybe bad merge happened?

@alex-kulakov
Copy link
Copy Markdown
Contributor

Yep, bad merge. Commit a8056d2

@AlexUstinov
Copy link
Copy Markdown
Contributor Author

We'll go forward with .Net Core 3.1 (See #58).

@AlexUstinov AlexUstinov closed this Sep 9, 2020
@AlexUstinov AlexUstinov deleted the net-standard-21 branch September 10, 2020 22:31
alex-kulakov pushed a commit that referenced this pull request Nov 24, 2021
* Memoize MakeGenericMethod()

* Memoize MakeGenericType()

* Improve readability
alex-kulakov added a commit that referenced this pull request Nov 24, 2021
Memoize MakeGenericMethod(), MakeGenericType() methods (#50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants