Merged
Conversation
Signed-off-by: popcorny <celu@infuseai.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates the VERSION file for the recce-cloud package from recce_cloud/VERSION to recce_cloud/recce_cloud/VERSION to fix version detection issues in nightly builds. The change updates the package structure to have the VERSION file in the same directory as __init__.py, making it easier to include in package distributions and reference during development.
Changes:
- Moved VERSION file from
recce_cloud/VERSIONtorecce_cloud/recce_cloud/VERSION - Updated version detection logic to try both package names (nightly and official) and fall back to the new VERSION file location
- Updated build configuration and CI/CD workflows to reference the new VERSION file path
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| recce_cloud/recce_cloud/init.py | Updated get_version() to check both package names and read VERSION from the same directory as __init__.py |
| recce_cloud/recce_cloud/VERSION | New VERSION file location containing version 1.32.0.dev0 |
| recce_cloud/pyproject.toml | Updated hatch version path from VERSION to recce_cloud/VERSION |
| .github/workflows/release.yaml | Updated release workflow to write version to new location |
| .github/workflows/nightly.yaml | Updated nightly build workflow to read/write version from new location |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Chore
What this PR does / why we need it:
The
recce-cloud versiondoes not work in nightly build.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: