Skip to content

Fix the recce-cloud version#1052

Merged
wcchang1115 merged 1 commit intomainfrom
chore/fix-recce-cloud-version
Jan 13, 2026
Merged

Fix the recce-cloud version#1052
wcchang1115 merged 1 commit intomainfrom
chore/fix-recce-cloud-version

Conversation

@popcornylu
Copy link
Copy Markdown
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Chore

What this PR does / why we need it:
The recce-cloud version does not work in nightly build.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Signed-off-by: popcorny <celu@infuseai.io>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the VERSION file for the recce-cloud package from recce_cloud/VERSION to recce_cloud/recce_cloud/VERSION to fix version detection issues in nightly builds. The change updates the package structure to have the VERSION file in the same directory as __init__.py, making it easier to include in package distributions and reference during development.

Changes:

  • Moved VERSION file from recce_cloud/VERSION to recce_cloud/recce_cloud/VERSION
  • Updated version detection logic to try both package names (nightly and official) and fall back to the new VERSION file location
  • Updated build configuration and CI/CD workflows to reference the new VERSION file path

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
recce_cloud/recce_cloud/init.py Updated get_version() to check both package names and read VERSION from the same directory as __init__.py
recce_cloud/recce_cloud/VERSION New VERSION file location containing version 1.32.0.dev0
recce_cloud/pyproject.toml Updated hatch version path from VERSION to recce_cloud/VERSION
.github/workflows/release.yaml Updated release workflow to write version to new location
.github/workflows/nightly.yaml Updated nightly build workflow to read/write version from new location

Copy link
Copy Markdown
Collaborator

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wcchang1115 wcchang1115 merged commit 3bcb326 into main Jan 13, 2026
19 checks passed
@wcchang1115 wcchang1115 deleted the chore/fix-recce-cloud-version branch January 13, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants