Fixed strategy class lookup#681
Merged
botandrose merged 1 commit intoDatabaseCleaner:mainfrom Mar 16, 2021
Alexander-Senko:main
Merged
Fixed strategy class lookup#681botandrose merged 1 commit intoDatabaseCleaner:mainfrom Alexander-Senko:main
botandrose merged 1 commit intoDatabaseCleaner:mainfrom
Alexander-Senko:main
Conversation
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 669 674 +5
=========================================
+ Hits 669 674 +5
Continue to review full report at Codecov.
|
Contributor
|
Great work! Thank you! |
This was referenced May 5, 2026
leoarnold
pushed a commit
to leoarnold/database_cleaner
that referenced
this pull request
May 5, 2026
Following up on DatabaseCleaner#681, we also need to camelize strategy names in the RSpec shared examples for cleaning strategies. For developer convenience, the methods for string manipulation were moved from the Cleaner class to a dedicated StringHelper module.
leoarnold
pushed a commit
to leoarnold/database_cleaner
that referenced
this pull request
May 5, 2026
Following up on DatabaseCleaner#681, we also need to camelize strategy names in the RSpec shared examples for cleaning strategies. For developer convenience, the methods for string manipulation were moved from the Cleaner class to a dedicated StringHelper module.
leoarnold
pushed a commit
to leoarnold/database_cleaner
that referenced
this pull request
May 5, 2026
Following up on DatabaseCleaner#681, we also need to camelize strategy names in the RSpec shared examples for cleaning strategies. For developer convenience, the methods for string manipulation were moved from the Cleaner class to a dedicated StringHelper module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strategy name should be
camelized, notcapitalized.Fixes #680.