Fix ClickHouse datatype handling and update test cases for consistency#188
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the ClickHouse connector to preserve ClickHouse’s native datatype strings (instead of lowercasing them) and updates decoding/tests to match, improving correctness and consistency between returned column metadata and value decoding.
Changes:
- Preserve
meta.typecasing inQueryColumn.datatype(stop lowercasing ClickHouse types). - Update ClickHouse value decoding to match ClickHouse’s canonical type names (e.g.,
Int32,Nullable(UInt64)). - Update integration/unit tests to assert the preserved datatype strings and reuse a shared password constant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src-crates/clickhouse/src/lib.rs |
Stops lowercasing returned column datatypes and updates integration tests to assert preserved type strings. |
src-crates/clickhouse/src/decode.rs |
Updates decoding logic and unit tests to match ClickHouse’s canonical (cased) datatype names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+533
to
+534
| assert_eq!(result.columns[0].datatype, "Int32"); | ||
| assert_eq!(result.columns[1].datatype, "Nullable(UInt64)"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.