update jspdf #440
Merged
update jspdf #440
+40
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warm-coolguy
requested review from
czirkelbach,
dopenguin and
oeninghe-dataport
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to a security vulnerability, the dependency
jspdfis updated from^2.5.2to^4.0.0. Neither of the breaking changes (3.0.0, 4.0.0) is relevant to POLAR. Furthermore, the vulnerability does not affect us, and no further action is required; simply phasing out the old version on an update anywhen, if at all, is sufficient.During the update, NPM automatically pulled
@babel/runtimefrom 7.27.0 to 7.28.4 for uninvestigated reasons. The prior import of'regenerator-runtime/runtime'to jest broke with this update. However, the import could simply be removed due to our minimum required version of Node no longer needing it.Instructions for local reproduction and review
snowbox-pdf.patch
May be tested in the snowbox with this change, which I did. Since the whole operation was rather straightforward, I do not deem repetition on your end necessary.
Pull Request Checklist (for Assignee)