DEV-13447 sg module rds #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souza-dan
reviewed
Apr 2, 2020
laferrieren
requested changes
Apr 2, 2020
laferrieren
left a comment
laferrieren
left a comment
There was a problem hiding this comment.
We should be clear in the readme that this module is solely meant for an rds instance that is meant to be used with tamr and not a generic rds module.
souza-dan
reviewed
Apr 3, 2020
Contributor
souza-dan
left a comment
souza-dan
left a comment
There was a problem hiding this comment.
Overall looks good, just a few more places to update the examples
cbelitz
reviewed
Apr 3, 2020
cbelitz
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do after the PR is approved and ready to merge: