Skip to content

Refactored CharacterTest #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaveRandom merged 2 commits into from
Jan 25, 2013
Merged

Refactored CharacterTest #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87c2ad5
Refactor CharacterTest to use a data provider
daviddesberg Jan 25, 2013
06df3f0
Changed test name to be more appropriate
daviddesberg Jan 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions tests/Code39/CharacterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,12 @@ public function testToString()
$this->assertSame('a', strval($character));
}

public function testTerminatorCharacter()
/**
* @dataProvider terminatorBarLayoutProvider
*/
public function testBarLayouts($character, $expectedBarLayout)
{
$expectedBarLayout = array(
array(1, true),
array(3, false),
array(1, true),
array(1, false),
array(3, true),
array(1, false),
array(3, true),
array(1, false),
array(1, true)
);

$character = new Character( chr(255) );
$character = new Character( $character );
$bars = $character->getBars();
$this->assertCount(count($expectedBarLayout), $bars);

Expand All @@ -45,4 +36,9 @@ public function testInvalidCharacter()
$this->setExpectedException( 'InvalidArgumentException' );
new Character( chr(129) );
}

public function terminatorBarLayoutProvider()
{
return include __DIR__ . '/../fixtures/Character/bar-layouts.php';
}
}
17 changes: 17 additions & 0 deletions tests/fixtures/Character/bar-layouts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php
return array(
array(
chr(255), /* character */
array( /* expected bar layout */
array(1, true),
array(3, false),
array(1, true),
array(1, false),
array(3, true),
array(1, false),
array(3, true),
array(1, false),
array(1, true)
)
)
);