Skip to content

perf: Optimize AnimatedList rendering with useCallback #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2025
+216 −28
Merged

perf: Optimize AnimatedList rendering with useCallback #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eefb5a6
perf: optimize content\Components\AnimatedList.jsx rendering with use…
EnderRomantice Nov 27, 2025
a7ebaa0
perf: optimize tailwind\Components\AnimatedList.jsx rendering with us…
EnderRomantice Nov 27, 2025
7da4a83
perf: optimize ts-default\Components\AnimatedList.tsx rendering with …
EnderRomantice Nov 27, 2025
990d139
perf: optimize ts-tailwind\Components\AnimatedList.tsx rendering with…
EnderRomantice Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions src/content/Components/AnimatedList/AnimatedList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useRef, useState, useEffect } from 'react';
import { useRef, useState, useEffect, useCallback } from 'react';
import { motion, useInView } from 'motion/react';
import './AnimatedList.css';

Expand Down Expand Up @@ -53,12 +53,26 @@ const AnimatedList = ({
const [topGradientOpacity, setTopGradientOpacity] = useState(0);
const [bottomGradientOpacity, setBottomGradientOpacity] = useState(1);

const handleScroll = e => {
const handleItemMouseEnter = useCallback(index => {
setSelectedIndex(index);
}, []);

const handleItemClick = useCallback(
(item, index) => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
},
[onItemSelect]
);

const handleScroll = useCallback(e => {
const { scrollTop, scrollHeight, clientHeight } = e.target;
setTopGradientOpacity(Math.min(scrollTop / 50, 1));
const bottomDistance = scrollHeight - (scrollTop + clientHeight);
setBottomGradientOpacity(scrollHeight <= clientHeight ? 0 : Math.min(bottomDistance / 50, 1));
};
}, []);

useEffect(() => {
if (!enableArrowNavigation) return;
Expand Down Expand Up @@ -115,13 +129,8 @@ const AnimatedList = ({
key={index}
delay={0.1}
index={index}
onMouseEnter={() => setSelectedIndex(index)}
onClick={() => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
}}
onMouseEnter={() => handleItemMouseEnter(index)}
onClick={() => handleItemClick(item, index)}
>
<div className={`item ${selectedIndex === index ? 'selected' : ''} ${itemClassName}`}>
<p className="item-text">{item}</p>
Expand Down
161 changes: 161 additions & 0 deletions src/tailwind/Components/AnimatedList/AnimatedList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { useRef, useState, useEffect } from 'react';
import { motion, useInView } from 'motion/react';

import { useRef, useState, useEffect, useCallback } from 'react';
import { motion, useInView } from 'motion/react';

const AnimatedItem = ({ children, delay = 0, index, onMouseEnter, onClick }) => {
const ref = useRef(null);
const inView = useInView(ref, { amount: 0.5, triggerOnce: false });
Expand All @@ -20,6 +23,164 @@ const AnimatedItem = ({ children, delay = 0, index, onMouseEnter, onClick }) =>
);
};

const AnimatedList = ({
items = [
'Item 1',
'Item 2',
'Item 3',
'Item 4',
'Item 5',
'Item 6',
'Item 7',
'Item 8',
'Item 9',
'Item 10',
'Item 11',
'Item 12',
'Item 13',
'Item 14',
'Item 15'
],
onItemSelect,
showGradients = true,
enableArrowNavigation = true,
className = '',
itemClassName = '',
displayScrollbar = true,
initialSelectedIndex = -1
}) => {
const listRef = useRef(null);
const [selectedIndex, setSelectedIndex] = useState(initialSelectedIndex);
const [keyboardNav, setKeyboardNav] = useState(false);
const [topGradientOpacity, setTopGradientOpacity] = useState(0);
const [bottomGradientOpacity, setBottomGradientOpacity] = useState(1);

const handleItemMouseEnter = useCallback((index) => {
setSelectedIndex(index);
}, []);

const handleItemClick = useCallback((item, index) => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
}, [onItemSelect]);

const handleScroll = useCallback((e) => {
const { scrollTop, scrollHeight, clientHeight } = e.target;
setTopGradientOpacity(Math.min(scrollTop / 50, 1));
const bottomDistance = scrollHeight - (scrollTop + clientHeight);
setBottomGradientOpacity(scrollHeight <= clientHeight ? 0 : Math.min(bottomDistance / 50, 1));
}, []);

useEffect(() => {
if (!enableArrowNavigation) return;
const handleKeyDown = e => {
if (e.key === 'ArrowDown' || (e.key === 'Tab' && !e.shiftKey)) {
e.preventDefault();
setKeyboardNav(true);
setSelectedIndex(prev => Math.min(prev + 1, items.length - 1));
} else if (e.key === 'ArrowUp' || (e.key === 'Tab' && e.shiftKey)) {
e.preventDefault();
setKeyboardNav(true);
setSelectedIndex(prev => Math.max(prev - 1, 0));
} else if (e.key === 'Enter') {
if (selectedIndex >= 0 && selectedIndex < items.length) {
e.preventDefault();
if (onItemSelect) {
onItemSelect(items[selectedIndex], selectedIndex);
}
}
}
};

window.addEventListener('keydown', handleKeyDown);
return () => window.removeEventListener('keydown', handleKeyDown);
}, [items, selectedIndex, onItemSelect, enableArrowNavigation]);

useEffect(() => {
if (!keyboardNav || selectedIndex < 0 || !listRef.current) return;
const container = listRef.current;
const selectedItem = container.querySelector(`[data-index="${selectedIndex}"]`);
if (selectedItem) {
const extraMargin = 50;
const containerScrollTop = container.scrollTop;
const containerHeight = container.clientHeight;
const itemTop = selectedItem.offsetTop;
const itemBottom = itemTop + selectedItem.offsetHeight;
if (itemTop < containerScrollTop + extraMargin) {
container.scrollTo({ top: itemTop - extraMargin, behavior: 'smooth' });
} else if (itemBottom > containerScrollTop + containerHeight - extraMargin) {
container.scrollTo({
top: itemBottom - containerHeight + extraMargin,
behavior: 'smooth'
});
}
}
setKeyboardNav(false);
}, [selectedIndex, keyboardNav]);

return (
<div className={`relative w-[500px] ${className}`}>
<div
ref={listRef}
className={`max-h-[400px] overflow-y-auto p-4 ${
displayScrollbar
? '[&::-webkit-scrollbar]:w-[8px] [&::-webkit-scrollbar-track]:bg-[#060010] [&::-webkit-scrollbar-thumb]:bg-[#222] [&::-webkit-scrollbar-thumb]:rounded-[4px]'
: 'scrollbar-hide'
}`}
onScroll={handleScroll}
style={{
scrollbarWidth: displayScrollbar ? 'thin' : 'none',
scrollbarColor: '#222 #060010'
}}
>
{items.map((item, index) => (
<AnimatedItem
key={index}
delay={0.1}
index={index}
onMouseEnter={() => handleItemMouseEnter(index)}
onClick={() => handleItemClick(item, index)}
>
<div className={`p-4 bg-[#111] rounded-lg ${selectedIndex === index ? 'bg-[#222]' : ''} ${itemClassName}`}>
<p className="text-white m-0">{item}</p>
</div>
</AnimatedItem>
))}
</div>
{showGradients && (
<>
<div
className="absolute top-0 left-0 right-0 h-[50px] bg-gradient-to-b from-[#060010] to-transparent pointer-events-none transition-opacity duration-300 ease"
style={{ opacity: topGradientOpacity }}
></div>
<div
className="absolute bottom-0 left-0 right-0 h-[100px] bg-gradient-to-t from-[#060010] to-transparent pointer-events-none transition-opacity duration-300 ease"
style={{ opacity: bottomGradientOpacity }}
></div>
</>
)}
</div>
);
};

export default AnimatedList;

ref={ref}
data-index={index}
onMouseEnter={onMouseEnter}
onClick={onClick}
initial={{ scale: 0.7, opacity: 0 }}
animate={inView ? { scale: 1, opacity: 1 } : { scale: 0.7, opacity: 0 }}
transition={{ duration: 0.2, delay }}
className="mb-4 cursor-pointer"
>
{children}
</motion.div>
);
};

const AnimatedList = ({
items = [
'Item 1',
Expand Down
29 changes: 19 additions & 10 deletions src/ts-default/Components/AnimatedList/AnimatedList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useRef, useState, useEffect, ReactNode, MouseEventHandler, UIEvent } from 'react';
import React, { useRef, useState, useEffect, useCallback, ReactNode, MouseEventHandler, UIEvent } from 'react';
import { motion, useInView } from 'motion/react';
import './AnimatedList.css';

Expand Down Expand Up @@ -72,13 +72,27 @@ const AnimatedList: React.FC<AnimatedListProps> = ({
const [topGradientOpacity, setTopGradientOpacity] = useState<number>(0);
const [bottomGradientOpacity, setBottomGradientOpacity] = useState<number>(1);

const handleScroll = (e: UIEvent<HTMLDivElement>) => {
const handleItemMouseEnter = useCallback((index: number) => {
setSelectedIndex(index);
}, []);

const handleItemClick = useCallback(
(item: string, index: number) => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
},
[onItemSelect]
);

const handleScroll = useCallback((e: UIEvent<HTMLDivElement>) => {
const target = e.target as HTMLDivElement;
const { scrollTop, scrollHeight, clientHeight } = target;
setTopGradientOpacity(Math.min(scrollTop / 50, 1));
const bottomDistance = scrollHeight - (scrollTop + clientHeight);
setBottomGradientOpacity(scrollHeight <= clientHeight ? 0 : Math.min(bottomDistance / 50, 1));
};
}, []);

useEffect(() => {
if (!enableArrowNavigation) return;
Expand Down Expand Up @@ -135,13 +149,8 @@ const AnimatedList: React.FC<AnimatedListProps> = ({
key={index}
delay={0.1}
index={index}
onMouseEnter={() => setSelectedIndex(index)}
onClick={() => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
}}
onMouseEnter={() => handleItemMouseEnter(index)}
onClick={() => handleItemClick(item, index)}
>
<div className={`item ${selectedIndex === index ? 'selected' : ''} ${itemClassName}`}>
<p className="item-text">{item}</p>
Expand Down
25 changes: 17 additions & 8 deletions src/ts-tailwind/Components/AnimatedList/AnimatedList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useRef, useState, useEffect, ReactNode, MouseEventHandler, UIEvent } from 'react';
import React, { useRef, useState, useEffect, useCallback, ReactNode, MouseEventHandler, UIEvent } from 'react';
import { motion, useInView } from 'motion/react';

interface AnimatedItemProps {
Expand Down Expand Up @@ -71,6 +71,20 @@ const AnimatedList: React.FC<AnimatedListProps> = ({
const [topGradientOpacity, setTopGradientOpacity] = useState<number>(0);
const [bottomGradientOpacity, setBottomGradientOpacity] = useState<number>(1);

const handleItemMouseEnter = useCallback((index: number) => {
setSelectedIndex(index);
}, []);

const handleItemClick = useCallback(
(item: string, index: number) => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
},
[onItemSelect]
);

const handleScroll = (e: UIEvent<HTMLDivElement>) => {
const { scrollTop, scrollHeight, clientHeight } = e.target as HTMLDivElement;
setTopGradientOpacity(Math.min(scrollTop / 50, 1));
Expand Down Expand Up @@ -145,13 +159,8 @@ const AnimatedList: React.FC<AnimatedListProps> = ({
key={index}
delay={0.1}
index={index}
onMouseEnter={() => setSelectedIndex(index)}
onClick={() => {
setSelectedIndex(index);
if (onItemSelect) {
onItemSelect(item, index);
}
}}
onMouseEnter={() => handleItemMouseEnter(index)}
onClick={() => handleItemClick(item, index)}
>
<div className={`p-4 bg-[#111] rounded-lg ${selectedIndex === index ? 'bg-[#222]' : ''} ${itemClassName}`}>
<p className="text-white m-0">{item}</p>
Expand Down