Implement and integrate a GTK app picker#6
Merged
Conversation
Waiting synchronously for the process to exit prevents a deadlock in the GUI counterpart
Passes the opened file's parsed type and path to the UI
Changes the UI scale factor based on the active monitor's DPI
Prevents the text from either overflowing or resizing the window
Reimplements the same functionality for the terminal app picker as well
The sourcing process spawns a new shell within the current one
The either spawned a subprocess or the existing process kept running in the background despite it seemingly exiting
Hides the entries from the corresponding graphical shell's app menu
Extracts the MIME type association to the XDG Desktop Entry
Prevents any tests requiring the local or portable config directory from running when they're already in use
Fixes the app freezing on Windows when the integration isn't complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.