feat(hatch hook): add support for exclude patterns as paths with wildcards #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidVujic
commented
Jun 6, 2025
Comment on lines
+53
to
+60
| def rewrite_modules(paths: List[Path], ns: str, top_ns: str) -> None: | ||
| for path in paths: | ||
| rewritten_bricks = parsing.rewrite_modules(path, ns, top_ns) | ||
|
|
||
| for item in rewritten_bricks: | ||
| print(f"Updated {item} with new top namespace for local imports.") | ||
|
|
||
|
|
Owner
Author
There was a problem hiding this comment.
This is refactored to separate function. The rewrite is only applicable when there's a defined top_ns (i.e. when publishing several public packages and to avoid namespace collisions).
DavidVujic
commented
Jun 6, 2025
Comment on lines
+30
to
+36
| def ignore_paths(root: Path, patterns: Set[str]): | ||
| def fn(current_path: str, names: List[str]): | ||
| current = Path(current_path).resolve() | ||
|
|
||
| return {name for name in names if any_match(root, patterns, name, current)} | ||
|
|
||
| return fn |
Owner
Author
There was a problem hiding this comment.
A custom ignore-function according to the way shutil uses ignore. The default shutil.ignore_patterns only handles names (files or folders) and will not ignore paths. That is why there's need of a custom ignore function.
|
6 tasks
DavidVujic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for exclude patterns that are paths, with or without wildcards.
Motivation and Context
Continued work from #339 and the discussion #338
This feature will make it possible to define exclude patterns in the Hatch config, such as:
How Has This Been Tested?
✅ CI
✅ Local testing using
hatch buildTypes of changes
Checklist: