fix: pre-installed gtag causes analytics.js plugin to not initialize#302
Merged
DavidWells merged 1 commit intoNov 9, 2022
Conversation
Author
|
also, let me know if you have a prettier config you want me to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's very common for other gtags (from universal analytics, google ads, etc) to already be loaded before analytics.js loads gtag. Before this fix, they would cause analytics.js not to load gtag in the initialize function, thus preventing google analytics from firing.
This fix checks if OUR gtag is loaded already, instead of checking if any gtag is loaded.