Skip to content

Conversation

@Davidyz
Copy link
Owner

@Davidyz Davidyz commented Jun 19, 2025

#200

Fix #201

@Davidyz Davidyz added enhancement New feature or request feature labels Jun 19, 2025
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (b70ded9) to head (c4bd65f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          21       21           
  Lines        1589     1589           
=======================================
  Hits         1581     1581           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davidyz Davidyz force-pushed the feat/conditional_hooks branch from 261506d to 2e3c8f2 Compare June 19, 2025 07:03
@Davidyz
Copy link
Owner Author

Davidyz commented Jun 19, 2025

@deas I've implemented the changes to the hooks that you proposed in #200 (in slightly different ways bc your snippet didn't quite work). It'll also throw warnings on hooks that are symlinked. Could you give this a try?

@deas
Copy link

deas commented Jun 19, 2025

@deas I've implemented the changes to the hooks that you proposed in #200 (in slightly different ways bc your snippet didn't quite work). It'll also throw warnings on hooks that are symlinked. Could you give this a try?

What was the part that did not work for you?

@Davidyz Davidyz marked this pull request as ready for review June 19, 2025 09:48
@Davidyz Davidyz force-pushed the feat/conditional_hooks branch from 65346a1 to c4bd65f Compare June 19, 2025 10:26
@Davidyz Davidyz merged commit 38f838c into main Jun 19, 2025
13 checks passed
@Davidyz Davidyz deleted the feat/conditional_hooks branch June 19, 2025 11:11
@deas
Copy link

deas commented Jun 19, 2025

Oops, already on main. Don't know how and when you release from main, so this ships via lazy.nvim. Guess I should learn a bit about the toolchain (never heard of pdm), so I can run and try vectorcode straight from a source folder.

@Davidyz
Copy link
Owner Author

Davidyz commented Jun 19, 2025

Oops, already on main. Don't know how and when you release from main, so this ships via lazy.nvim. Guess I should learn a bit about the toolchain (never heard of pdm), so I can run and try vectorcode straight from a source folder.

You don't need pdm to build from source. Pdm is only for development. Both uv tool and pipx support installing from a git URL or a local dir. As for the release, I just tag a commit with the version number, and a GitHub action workflow will take care of the rest. I think we're pretty close to the release. I plan to test with some more models and see how they work with the new tool schema, and if everything turns out okay, I'll make the release (hopefully no later than this weekend). This is not a core functionality so I'm not too concerned about it for this release. 0.7.0 is really more about giving LLMs the ability to vectorise things.

@deas
Copy link

deas commented Jun 19, 2025

I think we should document the ideas behind the hooks in general and also drop some comments in the fragments. It is just a few lines shell script - still anything but self explanatory. ;)

@Davidyz
Copy link
Owner Author

Davidyz commented Jun 20, 2025

we should document the ideas behind the hooks in general and also drop some comments in the fragments.

I'll do a full review of the readme/documentation before the 0.7 release (it's been a while since the last time I did this) and make changes where necessary. I'll briefly explain what the default hooks do in the changes. As for a detailed explanation on what each part of the shell script does, CodeCompanion+VectorCode did an exceptional job at locating the relevant code and explaining the hooks, so I'd say we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] handle the special case where the hooks are symlinks

3 participants