Add emoji reactions to acknowledge and report command status#23
Merged
DeDuckProject merged 2 commits intomainfrom Mar 13, 2026
Merged
Add emoji reactions to acknowledge and report command status#23DeDuckProject merged 2 commits intomainfrom
DeDuckProject merged 2 commits intomainfrom
Conversation
Owner
Author
|
/glimpse |
|
- Add dedicated `ack` job in demo.yml that reacts with 👀 immediately (no checkout/install needed — just `gh api`) so acknowledgment appears within ~30s of the comment instead of 2–5 minutes. - Move 👀 reaction into check.ts (runs before heavy deps) so external users of the action also get earlier acknowledgment without any workflow changes on their side. - Replace the reaction in index.ts with completion signals: 🎉 hooray on success, 😕 confused on pipeline failure. Both coexist with the initial 👀 on the comment. - Add demo.yml workflow steps for hooray (success) and confused (failure) as a belt-and-suspenders complement to the action-level reactions. - Add External-First Design Principle section to CLAUDE.md documenting that all changes must account for consumer repos using this action. https://claude.ai/code/session_01JHYRHYBPULqbjvS5eayG2e
76333e4 to
132ac46
Compare
Owner
Author
|
/glimpse |
2 similar comments
Owner
Author
|
/glimpse |
Owner
Author
|
/glimpse |
The `ack` job was defined in `demo.yml`, which triggers on both `pull_request` and `issue_comment`. On every PR push, GitHub would mark it as "Skipped" — visual noise in the checks list, especially for non-developer reviewers. Fix: move `ack` to `glimpse-ack.yml`, which only listens to `issue_comment`. It never triggers on `pull_request` events, so it never appears as a skipped check on PRs. The new file is clearly documented as OPTIONAL — the demo pipeline works without it. It only adds the immediate 👀 reaction UX. Also adds `issues: write` to the `demo` job so the hooray/confused completion reactions via `gh api` work reliably. https://claude.ai/code/session_01JHYRHYBPULqbjvS5eayG2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds GitHub emoji reactions to provide immediate visual feedback when users trigger the
/glimpsecommand on pull requests. The workflow now reacts with 👀 when a command is received, 🎉 when it succeeds, and 😕 when it fails.Key Changes
Workflow improvements (
demo.yml):ackjob that reacts with 👀 immediately upon detecting/glimpsecomment, running in parallel with the main demo job for faster acknowledgmentAction code refactoring (
packages/action/src/index.ts):addCommentReaction()helper functioncommentIdfor use throughout the action lifecycleCheck module update (
packages/action/src/check.ts):Documentation (
CLAUDE.md):Implementation Details
The acknowledgment reaction now happens in the
check.tsmodule rather thanindex.ts, ensuring external users see immediate feedback even if they only use the action's check functionality. The parallelackjob in the workflow provides an additional fast-path for acknowledgment without requiring any checkout or installation steps.All reactions are non-fatal (wrapped in try-catch) to ensure workflow failures don't cascade from reaction API errors.
https://claude.ai/code/session_01JHYRHYBPULqbjvS5eayG2e