fix: replace esbuild runtime usage with sucrase (pure JS, fully bundl…#32
Merged
DeDuckProject merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
…eable) esbuild was used at runtime in two places (config loading and demo script transpilation) and was marked --external in the bundle, causing "Cannot find package 'esbuild'" errors when the action runs on GitHub Actions (which doesn't install action node_modules). sucrase is a pure-JS TypeScript stripper with no native binary deps, so it bundles cleanly into dist/index.js and dist/check.js. Changes: - config/loader.ts: replace esbuild build() with sucrase transform() (writes tmp file next to original so relative imports resolve) - playwright-runner.ts: replace esbuild transformSync() with sucrase transform() - core/package.json: swap esbuild dep for sucrase - action/package.json: remove --external:esbuild from both bundle commands Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eable)
esbuild was used at runtime in two places (config loading and demo script transpilation) and was marked --external in the bundle, causing "Cannot find package 'esbuild'" errors when the action runs on GitHub Actions (which doesn't install action node_modules).
sucrase is a pure-JS TypeScript stripper with no native binary deps, so it bundles cleanly into dist/index.js and dist/check.js.
Changes: