fix: improve previewUrl resolution error messages and add tests#36
Merged
DeDuckProject merged 2 commits intomainfrom Mar 14, 2026
Merged
fix: improve previewUrl resolution error messages and add tests#36DeDuckProject merged 2 commits intomainfrom
DeDuckProject merged 2 commits intomainfrom
Conversation
When app.previewUrl is set to an env var name that isn't available in the workflow job, the action now fails with a descriptive message naming the missing variable, rather than the generic "No base URL available". Also export resolveBaseUrl and add unit tests covering all resolution paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ild dep in tests Importing from packages/action/src/index.ts in unit tests pulled in @git-glimpse/core by package name, which requires a prior build step that CI doesn't run for unit tests. Moving resolveBaseUrl to its own file with a direct source-path type import fixes the resolution error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When app.previewUrl is set to an env var name that isn't available in the workflow job, the action now fails with a descriptive message naming the missing variable, rather than the generic "No base URL available". Also export resolveBaseUrl and add unit tests covering all resolution paths.