Add missing unit tests for core modules#50
Merged
DeDuckProject merged 2 commits intomainfrom Mar 15, 2026
Merged
Conversation
Add 7 new test files covering previously untested modules: - change-summarizer: LLM response parsing, diff truncation, prompt construction - script-generator: retry logic, general vs specific prompts, markdown fence stripping - schema: Zod schema validation for all config types, defaults, edge cases - defaults: default config value assertions - github-comment: PR comment body construction, file truncation, media sections - pipeline: full pipeline orchestration with mocks, fallback to screenshots - post-processor: FFmpeg conversion modes, GIF palette method, ffmpeg resolution Test count: 96 → 150 (54 new tests) https://claude.ai/code/session_01PAVFqsnf36BamyXEiwS8DU
- Export buildCommentBody from github-comment.ts so tests can import it directly instead of reimplementing the function - Rewrite github-comment.test.ts to import and test the real function - Add "Diff truncation" section to README documenting the 8k/10k char limits in the change summarizer and script generator stages https://claude.ai/code/session_01PAVFqsnf36BamyXEiwS8DU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 7 new test files covering previously untested modules:
Test count: 96 → 150 (54 new tests)
https://claude.ai/code/session_01PAVFqsnf36BamyXEiwS8DU