Limit max tip age to reasonable value#499
Merged
Merged
Conversation
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
bvbfan
requested review from
Bushstar,
Mixa84,
ShengguangXiao,
monstrobishi,
surangap and
uzyn
as code owners
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
Bushstar
changed the title
Bushstar
changed the title
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
Bushstar
approved these changes
Jun 8, 2021
ShengguangXiao
approved these changes
Jun 8, 2021
Bushstar
approved these changes
Jun 10, 2021
bvbfan
added a commit
that referenced
this pull request
Jun 10, 2021
* Limit max tip age to reasonable value Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Limit max tip age to reasonable value Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> * Adopt max tip age to 80 min Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind fix
What this PR does / why we need it:
Max tip age is used in IBD it allows miners to start their work too early which can result in high hash error.
It's a safe value since leaving IBD is happen one time per run we cannot end with stalling masternode.
Fee estimation tip age is in direct connection to max tip age and should be lowered as well.