Skip to content

Increase time range for staking#514

Merged
Bushstar merged 7 commits into
masterfrom
feature-increase-stake-range
Jun 10, 2021
Merged

Increase time range for staking#514
Bushstar merged 7 commits into
masterfrom
feature-increase-stake-range

Conversation

@Bushstar

@Bushstar Bushstar commented Jun 9, 2021

Copy link
Copy Markdown
Contributor

debug.log sample with extra logging to show when and what nLastCoinStakeSearchTime and lastBlockSeen get set to, staking range shows the range of times to try.

https://gist.github.com/Bushstar/6abd686cc71c318cfd711f331452993a

bvbfan
bvbfan previously approved these changes Jun 9, 2021
uzyn
uzyn previously approved these changes Jun 9, 2021

@uzyn uzyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread src/miner.cpp Outdated
Comment thread src/miner.cpp Outdated
@Bushstar Bushstar dismissed stale reviews from uzyn and bvbfan via 1617f15 June 9, 2021 15:04
@Bushstar Bushstar force-pushed the feature-increase-stake-range branch from dc33097 to 1617f15 Compare June 9, 2021 15:04
uzyn
uzyn previously approved these changes Jun 9, 2021

@uzyn uzyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment fix

Comment thread src/miner.cpp Outdated
Comment thread src/miner.cpp
monstrobishi
monstrobishi previously approved these changes Jun 10, 2021
@ShengguangXiao

Copy link
Copy Markdown
Contributor

If the lastSearchTime < currentTime < futureTime, then the time range between lastSearchTime and currentTime is searched for two times, is this designated?

@Bushstar

Copy link
Copy Markdown
Contributor Author

@ShengguangXiao thanks for spotting this, will update. This works on subsequent loops but the first is a duplication of effort.

@Bushstar Bushstar requested a review from ShengguangXiao June 10, 2021 11:01
ShengguangXiao
ShengguangXiao previously approved these changes Jun 10, 2021
@Bushstar Bushstar merged commit 626b2de into master Jun 10, 2021
@Bushstar Bushstar deleted the feature-increase-stake-range branch June 10, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants