Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Aligns agent launches and recovery with terminal profile semantics so agent windows on Windows inherit the same shell/runtime behavior as terminals. This fixes three user-facing regressions: agent sessions failing to inherit environment/runtime on some devices, recovery relaunches silently losing execution context, and wheel input in raw TUI agent windows not being covered by a regression test.
🏗️ Large Change Spec (Required if "Large Change" is checked)
1. Context & Business Logic
2. State Ownership & Invariants
profileId,runtimeKind,executionDirectory, andresumeSessionIdmetadata used during hydration.agent.executionDirectoryto workspace root.profileIdis still forwarded so the shell environment stays consistent.3. Verification Plan & Regression Layer
pnpm pre-commitcoverage.✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.DEVELOPMENT.mdarchitectural boundaries.📸 Screenshots / Visual Evidence