Fix URI decoding and add test #1
Conversation
The 'decode' function in 'src/js/util.js' was vulnerable to infinite recursion with certain malformed URI strings. It also failed to decode some valid URI-encoded strings. This commit replaces the recursive implementation with an iterative 'while' loop. This is a more robust way to handle repeated decoding and prevents stack overflow errors. A new test case has been added to 'tools/test_decode.js' to verify the fix. The test fails before the fix and passes after, proving the bug is resolved.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
The decode function in 'src/js/util.js' was vulnerable to infinite recursion and failed to decode certain URI-encoded strings. This has been fixed by replacing the recursive implementation with a more robust iterative approach. A new test file has also been added to verify the fix and prevent regressions.
PR created automatically by Jules for task 9477272535847196310