Remove JSONValueNode defaultProps. #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean177
approved these changes
Feb 4, 2025
Owner
|
Published in 1.5.0 |
Owner
|
Thanks @iressler |
Contributor
Author
|
Thanks for getting it merged & released so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160 & #164 identified several warnings/errors due to props issues, most of which were resolved in #161 & #162. However
JSONValueNode'sdefaultPropswas not included in either of the fixes.These changes move the default values from
defaultPropsto the parameters.I'm not sure how to really test these changes, but they haven't caused any issues in our app.
Shout out to @trajano who identified this issue in both threads, and supplied a patch with the fix.