Skip to content

Conversation

@DecSmith42
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 7, 2025 02:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes prerelease flags and cleans up outdated workflow definitions, while standardizing API annotations and usings across projects.

  • Eliminates --prerelease references in both GitHub and Azure DevOps workflow writers.
  • Deletes obsolete .github and .devops YAML workflows for manual parameters and custom artifacts.
  • Adds [PublicAPI] annotations and tidies up global usings in various modules.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
_atom/_usings.cs Removed unused global using DecSm.Atom.BuildInfo
_atom/Build.cs Removed the Test_BuildWithCustomArtifacts workflow block
DecSm.Atom.Module.GithubWorkflows/_usings.cs Added global using System.Globalization
DecSm.Atom.Module.GithubWorkflows/Generation/GithubWorkflowWriter.cs Dropped --prerelease flag and removed the corresponding TODO
DecSm.Atom.Module.GithubWorkflows/Expressions.cs Added [PublicAPI] to expressions and removed obsolete usings
DecSm.Atom.Module.GithubWorkflows.Tests/Workflows/GithubIfBuild.cs Introduced #pragma warning disable CA1822 for test class
DecSm.Atom.Module.DevopsWorkflows/Generation/DevopsWorkflowWriter.cs Dropped --prerelease flag in DevOps script step
DecSm.Atom.Analyzers/Resources.resx Updated XML formatting and added ReSharper disable directive
DecSm.Atom.Analyzers/AT0001_TargetRequiringParamShouldNotDirectlyReferenceParamCodeFixProvider.cs Reformatted method signature to static async with multi-line args
DecSm.Atom.Analyzers/AT0001_TargetRequiringParamShouldNotDirectlyReferenceParamAnalyzer.cs Made AnalyzeOperation static
DecSm.Atom.Analyzers.Tests/ExtendedCodeFixVerifier.cs Added JetBrains Annotations import and [PublicAPI] to helper
DecSm.Atom.Analyzers.Tests/ExtendedAnalyzerVerifier.cs Added JetBrains Annotations import and [PublicAPI] to helper
DecSm.Atom.Analyzers.Sample/AT0001_TargetRequiringParamShouldNotDirectlyReferenceParam.cs Added JetBrains Annotations import and [PublicAPI] to interface
.github/workflows/Test_ManualParams.yml Removed obsolete workflow file
.github/workflows/Test_BuildWithCustomArtifacts.yml Removed obsolete workflow file
.devops/workflows/Test_ManualParams.yml Removed obsolete workflow file
.devops/workflows/Test_BuildWithCustomArtifacts.yml Removed obsolete workflow file
Comments suppressed due to low confidence (2)

DecSm.Atom.Module.GithubWorkflows/Expressions.cs:1

  • The [PublicAPI] attribute is used throughout this file but the JetBrains.Annotations namespace isn't imported. Add using JetBrains.Annotations; at the top to ensure the attributes resolve correctly.
namespace DecSm.Atom.Module.GithubWorkflows;

DecSm.Atom.Module.GithubWorkflows.Tests/Workflows/GithubIfBuild.cs:1

  • [nitpick] Consider adding a matching #pragma warning restore CA1822 after the class definition to limit the scope of this suppression and avoid hiding other unintended warnings.
#pragma warning disable CA1822

@DecSmith42 DecSmith42 enabled auto-merge June 7, 2025 02:34
@DecSmith42 DecSmith42 disabled auto-merge June 7, 2025 02:34
@DecSmith42 DecSmith42 enabled auto-merge June 7, 2025 02:40
@DecSmith42 DecSmith42 merged commit 6543878 into main Jun 7, 2025
37 of 39 checks passed
@DecSmith42 DecSmith42 deleted the remove-prerelease-refs branch June 7, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant