feat(AzureKeyVault): add support for configurable auth redirect port #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `AzureVaultAuthPort` parameter to allow configuring the port used for local authentication redirect during Azure Key Vault authentication. Defaults to 3421, with an option to use a random port by setting it to 0. Updated `InteractiveBrowserCredential` setup to respect the configured redirect port. Fixed branch type regex in `GitVersion.yml`.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configurable authentication redirect ports in Azure Key Vault integration and fixes a regex pattern in GitVersion configuration. The new AzureVaultAuthPort parameter allows users to specify the local port used during interactive browser authentication, with a default of 3421 and support for random port selection when set to 0.
Key changes:
- Added
AzureVaultAuthPortparameter with default value 3421 and support for random port (value 0) - Updated
InteractiveBrowserCredentialinitialization to use the configured port for redirect URI - Fixed GitVersion.yml branch type regex to make
BranchTypemandatory instead of optional
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| GitVersion.yml | Fixed branch type regex to make BranchType capture group mandatory |
| DecSm.Atom.Module.AzureKeyVault/IAzureKeyVault.cs | Added AzureVaultAuthPort parameter definition with documentation |
| DecSm.Atom.Module.AzureKeyVault/AzureKeySecretsProvider.cs | Implemented port retrieval logic and configured InteractiveBrowserCredential RedirectUri |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
AzureVaultAuthPortparameter to allow configuring the port used for local authentication redirect during Azure Key Vault authentication. Defaults to 3421, with an option to use a random port by setting it to 0.Updated
InteractiveBrowserCredentialsetup to respect the configured redirect port. Fixed branch type regex inGitVersion.yml.