Improvement/GitHub token permissions #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new default GitHub workflow permissions configuration that sets permissions to "none" by default, both in workflow YAML files and in the code that generates them. Additionally, it removes support for the obsolete
artifact-metadataandmodelspermissions, and provides a new utility for applying the "none" permissions option in workflow definitions.Key changes:
Default Permissions Handling:
permissions: { }to.github/workflows/Build.ymland.github/workflows/Validate.ymlto explicitly set default permissions to none in these workflows. [1] [2]GithubTokenPermissionsOption.NoneAll, a static option that sets all permissions toNone, and applied it to workflow definitions in_atom/Build.cs. [1] [2] [3]permissions: { }whenNoneAllis selected.Permissions Option Refactoring:
artifact-metadataandmodelsproperties fromGithubTokenPermissionsOptionand their usage throughout the codebase. [1] [2] [3] [4]API Improvements:
WithGithubTokenPermissionsfor easier application of permissions options to workflow target definitions.