fix(generator): filter out compiler-generated attributes from parameters #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `GenerateInterfaceMembersSourceGenerator` to exclude attributes within the `System.Runtime.CompilerServices` namespace from method parameter processing. This prevents unintended inclusion and ensures the generated code focuses on user-defined attributes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GenerateInterfaceMembersSourceGenerator to filter out compiler-generated attributes from the System.Runtime.CompilerServices namespace when processing method parameters. The goal is to prevent these internal attributes from appearing in generated interface member implementations, ensuring the generated code only includes user-defined attributes.
Key changes:
- Modified attribute collection logic to exclude
System.Runtime.CompilerServicesattributes using a LINQ filter - Changed from simple
GetAttributes()to a filtered query withWhereclause andToArray()materialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DecSmith42
deleted the
fix/generate-interface-memebers-attribute-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
GenerateInterfaceMembersSourceGeneratorto exclude attributes within theSystem.Runtime.CompilerServicesnamespace from method parameter processing. This prevents unintended inclusion and ensures the generated code focuses on user-defined attributes.